golang/gogitlabber
golang/gogitlabber
3
0
Fork 0
Code Issues 1 Pull requests Releases 1 Activity

fix: nil pointer dereference error when in debug mode

Browse source
This commit is contained in:
Simon Cornet 2025-03-06 10:02:43 +01:00
commit fee0eaaed7
6 changed files with 86 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

28
cmd/gogitlabber/git.go
View file

@ -38,7 +38,7 @@ func checkoutRepositories(repositories []Repository, concurrency int) {
repoDestination := repoDestinationPre + repoName
// log activity
logging.Print(debug, "Starting on repository: "+repoName, nil)
logging.Print("Starting on repository: "+repoName, nil)
// make gitlab url
url := fmt.Sprintf("https://gitlab-token:%s@%s/%s.git", gitlabToken, gitlabHost, repoName)
@ -47,7 +47,7 @@ func checkoutRepositories(repositories []Repository, concurrency int) {
checkRepo := func(repoDestination string) string {
checkCmd := exec.Command("git", "-C", repoDestination, "remote", "-v")
checkOutput, _ := checkCmd.CombinedOutput()
logging.Print(debug, "Checking status for repository: "+repoName, nil)
logging.Print("Checking status for repository: "+repoName, nil)
return string(checkOutput)
}
@ -59,19 +59,19 @@ func checkoutRepositories(repositories []Repository, concurrency int) {
case strings.Contains(string(repoStatus), "No such file or directory"):
// log activity
logging.Print(debug, "Decided to clone repository: "+repoName, nil)
logging.Print("Decided to clone repository: "+repoName, nil)
// clone the repo
cloneRepository := func(repoDestination string, url string) (string, error) {
cloneCmd := exec.Command("git", "clone", url, repoDestination)
cloneOutput, err := cloneCmd.CombinedOutput()
logging.Print(debug, "Cloning repository: "+repoName+" to "+repoDestination, nil)
logging.Print("Cloning repository: "+repoName+" to "+repoDestination, nil)
return string(cloneOutput), err
}
_, err := cloneRepository(repoDestination, url)
if err != nil {
logging.Print(debug, "ERROR: %v\n", err)
logging.Print("ERROR: %v\n", err)
}
// set a lock, increment counters, update progressbar and unlock
@ -88,7 +88,7 @@ func checkoutRepositories(repositories []Repository, concurrency int) {
// pull the latest
case strings.Contains(string(repoStatus), url):
logging.Print(debug, "Decided to pull repository: "+repoName, nil)
logging.Print("Decided to pull repository: "+repoName, nil)
pullRepository(repoName, repoDestination)
if !debug {
descriptionPrefixPre := "Pulling repository "
@ -98,8 +98,8 @@ func checkoutRepositories(repositories []Repository, concurrency int) {
}
default:
logging.Print(debug, "ERROR: decided not to clone or pull repository: "+repoName, nil)
logging.Print(debug, "ERROR: this is why: "+repoStatus, nil)
logging.Print("ERROR: decided not to clone or pull repository: "+repoName, nil)
logging.Print("ERROR: this is why: "+repoStatus, nil)
// set a lock, increment counters and unlock
mu.Lock()
@ -119,7 +119,7 @@ func checkoutRepositories(repositories []Repository, concurrency int) {
func pullRepository(repoName string, repoDestination string) {
// log activity
logging.Print(debug, "Pulling repository: "+repoName+" at "+repoDestination, nil)
logging.Print("Pulling repository: "+repoName+" at "+repoDestination, nil)
// find remote
findRemote := func(repoDestination string) (string, error) {
@ -129,9 +129,9 @@ func pullRepository(repoName string, repoDestination string) {
return "", fmt.Errorf("finding remote: %v\n", err)
}
logging.Print(debug, "Finding remote for repository: "+repoName+" at "+repoDestination, nil)
logging.Print("Finding remote for repository: "+repoName+" at "+repoDestination, nil)
remote := strings.Split(strings.TrimSpace(string(remoteOutput)), "\n")[0]
logging.Print(debug, "Found remote; "+remote+" for repository: "+repoName+" at "+repoDestination, nil)
logging.Print("Found remote; "+remote+" for repository: "+repoName+" at "+repoDestination, nil)
return remote, nil
}
remote, _ := findRemote(repoDestination)
@ -156,13 +156,13 @@ func pullRepository(repoName string, repoDestination string) {
switch {
case strings.Contains(string(pullOutput), "You have unstaged changes"):
pullErrorMsg = append(pullErrorMsg, repoDestination)
logging.Print(debug, "Found unstaged changes for repository: "+repoName+" at "+repoDestination, nil)
logging.Print("Found unstaged changes for repository: "+repoName+" at "+repoDestination, nil)
default:
logging.Print(debug, "ERROR: pulling "+repoName, nil)
logging.Print("ERROR: pulling "+repoName, nil)
}
}
// log activity
logging.Print(debug, "Pulled repository: "+repoName+" at "+repoDestination, nil)
logging.Print("Pulled repository: "+repoName+" at "+repoDestination, nil)
}