From 3bb5474edf72e8912c60272fd63cbd56115ee1a7 Mon Sep 17 00:00:00 2001 From: Simon Cornet Date: Wed, 26 Feb 2025 07:46:10 +0100 Subject: [PATCH] feat: unified error handling --- cmd/gogitlabber/gitlab.go | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/cmd/gogitlabber/gitlab.go b/cmd/gogitlabber/gitlab.go index 9f3742b..d14bb7a 100644 --- a/cmd/gogitlabber/gitlab.go +++ b/cmd/gogitlabber/gitlab.go @@ -30,7 +30,7 @@ func fetchRepositoriesGitlab() ([]Repository, error) { req, err := http.NewRequest("GET", url, nil) if err != nil { - return nil, fmt.Errorf("error: creating request; %v", err) + return nil, fmt.Errorf("creating request: %v", err) } req.Header.Set("PRIVATE-TOKEN", gitlabToken) @@ -38,23 +38,22 @@ func fetchRepositoriesGitlab() ([]Repository, error) { client := &http.Client{} resp, err := client.Do(req) if err != nil { - return nil, fmt.Errorf("error: making request; %v", err) + return nil, fmt.Errorf("making request: %v", err) } defer resp.Body.Close() if resp.StatusCode != http.StatusOK { - return nil, fmt.Errorf("error: API request failed with status; %d", resp.StatusCode) + return nil, fmt.Errorf("API request failed with status: %d", resp.StatusCode) } var repositories []Repository if err := json.NewDecoder(resp.Body).Decode(&repositories); err != nil { - return nil, fmt.Errorf("error: decoding response; %v", err) + return nil, fmt.Errorf("decoding response: %v", err) } - if len(repositories) < 1 { - fmt.Fprintf(os.Stderr, "error: no repositories found\n") - os.Exit(1) - } + if len(repositories) < 1 { + return nil, fmt.Errorf("no repositories found") + } return repositories, nil }