From 4f76ad3afe270d03a860fb68b3659cc35dd6dc44 Mon Sep 17 00:00:00 2001
From: Simon Cornet <simon@simoncor.net>
Date: Sat, 21 Mar 2026 15:25:45 +0100
Subject: [PATCH] feat: improve ceph flags

---
 tasks/ceph/enter-maint.yaml | 41 +++++++++++--------------------------
 tasks/ceph/exit-maint.yaml  | 41 +++++++++++--------------------------
 2 files changed, 24 insertions(+), 58 deletions(-)

diff --git a/tasks/ceph/enter-maint.yaml b/tasks/ceph/enter-maint.yaml
index bedebc1..78d5356 100644
--- a/tasks/ceph/enter-maint.yaml
+++ b/tasks/ceph/enter-maint.yaml
@@ -4,34 +4,17 @@
 - name: "enable ceph maintenance mode"
   block:
 
-    # set ceph osd noout settings
-    - name: "set ceph noout"
+    # set ceph maintenance flags
+    - name: "set ceph maintenance flags"
       ansible.builtin.shell:
-        cmd: "ceph osd set noout"
+        cmd: "ceph osd set {{ item }}"
+      loop:
+        - "norecover"
+        - "norebalance"
+        - "nobackfill"
+        - "noscrub"
+        - "nodeep-scrub"
+        - "noout"
+      register: "ceph_flag_result"
       changed_when: false
-      failed_when: "ceph_noout_result.rc != 0"
-      register: "ceph_noout_result"
-
-    # set ceph osd nobackfill settings
-    - name: "set ceph nobackfill"
-      ansible.builtin.shell:
-        cmd: "ceph osd set nobackfill"
-      changed_when: false
-      failed_when: "ceph_nobackfill_result.rc != 0"
-      register: "ceph_nobackfill_result"
-
-    # set ceph osd norebalance settings
-    - name: "set ceph norebalance"
-      ansible.builtin.shell:
-        cmd: "ceph osd set norebalance"
-      changed_when: false
-      failed_when: "ceph_norebalance_result.rc != 0"
-      register: "ceph_norebalance_result"
-
-    # set ceph osd norecover settings
-    - name: "set ceph norecover"
-      ansible.builtin.shell:
-        cmd: "ceph osd set norecover"
-      changed_when: false
-      failed_when: "ceph_norecover_result.rc != 0"
-      register: "ceph_norecover_result"
+      failed_when: "ceph_flag_result.rc != 0"
diff --git a/tasks/ceph/exit-maint.yaml b/tasks/ceph/exit-maint.yaml
index 38f6068..812b754 100644
--- a/tasks/ceph/exit-maint.yaml
+++ b/tasks/ceph/exit-maint.yaml
@@ -4,34 +4,17 @@
 - name: "exit ceph maintenance mode"
   block:
 
-    # unset ceph osd noout settings
-    - name: "unset ceph noout"
+    # unset ceph maintenance flags
+    - name: "unset ceph maintenance flags"
       ansible.builtin.shell:
-        cmd: "ceph osd unset noout"
+        cmd: "ceph osd unset {{ item }}"
+      loop:
+        - "norecover"
+        - "norebalance"
+        - "nobackfill"
+        - "noscrub"
+        - "nodeep-scrub"
+        - "noout"
+      register: "ceph_flag_result"
       changed_when: false
-      failed_when: "ceph_noout_result.rc != 0"
-      register: "ceph_noout_result"
-
-    # unset ceph osd nobackfill settings
-    - name: "unset ceph nobackfill"
-      ansible.builtin.shell:
-        cmd: "ceph osd unset nobackfill"
-      changed_when: false
-      failed_when: "ceph_nobackfill_result.rc != 0"
-      register: "ceph_nobackfill_result"
-
-    # unset ceph osd norebalance settings
-    - name: "unset ceph norebalance"
-      ansible.builtin.shell:
-        cmd: "ceph osd unset norebalance"
-      changed_when: false
-      failed_when: "ceph_norebalance_result.rc != 0"
-      register: "ceph_norebalance_result"
-
-    # unset ceph osd norecover settings
-    - name: "unset ceph norecover"
-      ansible.builtin.shell:
-        cmd: "ceph osd unset norecover"
-      changed_when: false
-      failed_when: "ceph_norecover_result.rc != 0"
-      register: "ceph_norecover_result"
+      failed_when: "ceph_flag_result.rc != 0"