feat: fix users loop

tasks/main.yaml

@@ -180,6 +180,9 @@
 - name: "user - create users"
   ansible.builtin.include_tasks: "user.yaml"
   tags: "usermanagement"
+  loop: "{{ users }}"
+  loop_control:
+    loop_var: "__user"
 
 # firewall
 - name: "firewall"

tasks/user.yaml

@@ -1,24 +1,15 @@
 ---
 
-# manage users
+# manage facts
-- name: "manage users"
+- name: "user - set default facts for {{ __user['username'] }}"
-  tags: "usermanagement"
-  loop: "{{ user }}"
-  loop_control:
-    loop_var: "__user"
-
-  block:
-
-    # manage facts
-    - name: "user - set default facts for {{ __user['username'] }}"
   ansible.builtin.set_fact:
     sudo_hosts: "{{ __user['hosts'] | default('all') }}"
     sudo_file: "{{ __user['sudo'] | default('False') }}"
     sudo_pwless: "{{ __user['sudo_passwordless'] | default('False') }}"
     user_state: "{{ __user['state'] | default('present') }}"
 
-    # create user with password
+# create user with password
-    - name: "user - create users with password - {{ __user['username'] }}"
+- name: "user - create users with password - {{ __user['username'] }}"
   ansible.builtin.user:
     name: "{{ __user['username'] }}"
     comment: "{{ __user['name'] }}"
@@ -29,8 +20,8 @@
     - "__user['password'] is defined"
     - "user_state == 'present'"
 
-    # create user without password
+# create user without password
-    - name: "user - create users without password - {{ __user['username'] }}"
+- name: "user - create users without password - {{ __user['username'] }}"
   ansible.builtin.user:
     name: "{{ __user['username'] }}"
     comment: "{{ __user['name'] }}"
@@ -40,8 +31,8 @@
     - "__user['password'] is not defined"
     - "user_state == 'present'"
 
-    # manage authorized_keys
+# manage authorized_keys
-    - name: "user - manage authorized_keys - {{ __user['username'] }}"
+- name: "user - manage authorized_keys - {{ __user['username'] }}"
   ansible.posix.authorized_key:
     user: "{{ __user['username'] }}"
     key: "{{ __user['publickey'] }}"
@@ -49,16 +40,16 @@
     manage_dir: "true"
   when: "__user['publickey'] is defined"
 
-    # delete users
+# delete users
-    - name: "user - delete users - {{ __user['username'] }}"
+- name: "user - delete users - {{ __user['username'] }}"
   ansible.builtin.user:
     name: "{{ __user['username'] }}"
     state: "absent"
     remove: true
   when: "user_state == 'absent'"
 
-    # manage sudoers file
+# manage sudoers file
-    - name: "user - create sudoers file - {{ __user['username'] }}"
+- name: "user - create sudoers file - {{ __user['username'] }}"
   ansible.builtin.template:
     src: "templates/usermanagement/sudoers.d/sudoers.j2"
     dest: "/etc/sudoers.d/{{ __user['username'] }}"
@@ -67,7 +58,7 @@
     mode: "0644"
   when: "sudo_file"
 
-    - name: "user - delete sudoers file - {{ __user['username'] }}"
+- name: "user - delete sudoers file - {{ __user['username'] }}"
   ansible.builtin.file:
     state: "absent"
     path: "/etc/sudoers.d/{{ __user['username'] }}"