From c3fc60e33d90e8dc5833c5e17c0182bf97cbcc5d Mon Sep 17 00:00:00 2001
From: Simon Cornet <simon@simoncor.net>
Date: Fri, 18 Jul 2025 17:07:51 +0200
Subject: [PATCH] feat: optimized install steps

---
 tasks/install.yaml   | 35 ++++++++++-------------------------
 tasks/main.yaml      |  7 -------
 tasks/ossupport.yaml | 16 ----------------
 3 files changed, 10 insertions(+), 48 deletions(-)
 delete mode 100644 tasks/ossupport.yaml

diff --git a/tasks/install.yaml b/tasks/install.yaml
index a6de661..8c7759d 100644
--- a/tasks/install.yaml
+++ b/tasks/install.yaml
@@ -15,26 +15,12 @@
     state: "absent"
   when: "atuin_version not in atuin_version_check.stdout"
 
-# download atuin
-- name: "download atuin"
-  ansible.builtin.get_url:
-    url:
-      "https://github.com/atuinsh/atuin/releases/download/\
-       v{{ atuin_version }}/atuin-x86_64-unknown-linux-gnu.tar.gz"
-    dest: "/tmp/"
-    checksum:
-      "sha256:https://github.com/atuinsh/atuin/releases/download/\
-       v{{ atuin_version }}/atuin-x86_64-unknown-linux-gnu.tar.gz.sha256"
-    owner: "root"
-    group: "root"
-    mode: "0775"
-  register: "atuin_download"
-  when: "atuin_version not in atuin_version_check.stdout"
-
 # install atuin
 - name: "install atuin"
   ansible.builtin.unarchive:
-    src: "/tmp/atuin-x86_64-unknown-linux-gnu.tar.gz"
+    src:
+      "https://github.com/atuinsh/atuin/releases/download/\
+       v{{ atuin_version }}/atuin-x86_64-unknown-linux-gnu.tar.gz"
     dest: "/usr/local/bin/"
     include: "atuin-x86_64-unknown-linux-gnu/atuin"
     extra_opts: ["--strip-components=1"]
@@ -43,9 +29,7 @@
     mode: "0755"
     remote_src: true
   notify: "restart atuin"
-  when:
-    - "atuin_download.changed"
-    - "atuin_version not in atuin_version_check.stdout"
+  when: "atuin_version not in atuin_version_check.stdout"
 
 # install systemd service
 - name: "install service"
@@ -57,9 +41,10 @@
     mode: "0644"
   notify: "restart atuin"
 
-# cleanup atuin
-- name: "cleanup atuin installer"
+# create config directory
+- name: "create atuin config dir"
   ansible.builtin.file:
-    path: "/tmp/atuin-x86_64-unknown-linux-gnu.tar.gz"
-    state: "absent"
-  when: "atuin_version not in atuin_version_check.stdout"
+    path: "/etc/atuin"
+    state: "directory"
+    owner: "root"
+    group: "root"
diff --git a/tasks/main.yaml b/tasks/main.yaml
index c6b44e5..f17ecbb 100644
--- a/tasks/main.yaml
+++ b/tasks/main.yaml
@@ -1,20 +1,13 @@
 ---
 
-# check os support
-- name: "check for os support"
-  ansible.builtin.import_tasks: "ossupport.yaml"
-
 # load os variables
 - name: "include os specific vars"
   ansible.builtin.include_vars: "{{ ansible_os_family }}.yaml"
-  when: "os_support"
 
 # import install
 - name: "install"
   ansible.builtin.import_tasks: "install.yaml"
-  when: "os_support"
 
 # import config
 - name: "config"
   ansible.builtin.import_tasks: "config.yaml"
-  when: "os_support"
diff --git a/tasks/ossupport.yaml b/tasks/ossupport.yaml
deleted file mode 100644
index 3507753..0000000
--- a/tasks/ossupport.yaml
+++ /dev/null
@@ -1,16 +0,0 @@
----
-
-# support debian 12
-- name: "check for os support"
-  ansible.builtin.set_fact:
-    os_support: true
-  when:
-    - 'ansible_distribution == "Debian"'
-    - 'ansible_distribution_major_version == "12"'
-
-# fail role when not supported
-- name: "unsupported role"
-  ansible.builtin.fail:
-    msg: "This role not supported on this Operating System."
-  when:
-    - "os_support is not defined"